[PATCH 4/4] pata_samsung: Add Samsung PATA controller driver

Jassi Brar jassisinghbrar at gmail.com
Thu May 27 04:43:47 EDT 2010


On Thu, May 27, 2010 at 5:22 PM, Kukjin Kim <kgene.kim at samsung.com> wrote:
> From: Abhilash Kesavan <a.kesavan at samsung.com>
>
> Adds support for the Samsung PATA controller. This driver is based on the
> Libata subsystem and references the earlier patches sent for IDE subsystem.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan at samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> ---
>  drivers/ata/Kconfig        |    9 +
>  drivers/ata/Makefile       |    1 +
>  drivers/ata/pata_samsung.c |  591

Fasten your seat belts before reading further....

Rather than generic 'samsung', I would suggest the driver named
after the SoC, that is supported first(chronologically) in mainline kernel.
All newer SoCs should be simply taken to contain the controller of that SoC.
Otherwise, the same naming problem comes back to haunt us should
Samsung decides to use a different IP in future SoCs. What would we
call that driver? pata_samsung_v2.c ?

my two sparks
Jassi



More information about the linux-arm-kernel mailing list