[PATCH] mach-ep93xx: checkpatch.pl cleanup

H Hartley Sweeten hartleys at visionengravers.com
Thu May 6 16:19:37 EDT 2010


On Thursday, May 06, 2010 1:17 PM, Ryan Mallon wrote:
> H Hartley Sweeten wrote:
>> This cleans up most the checkpatch.pl issues in mach-ep93xx.
>> 
>>   ERROR: space required after that ',' (ctx:VxV)
>>   WARNING: line over 80 characters
>>   WARNING: please, no space before tabs
>> 
>> The file core.c still produces this warning:
>> 
>>   WARNING: externs should be avoided in .c files
>> 
>> Due to two externs declared for functions in located in gpio.c.
>> Since these are __init functions, and not meant to be exposed,
>> these warnings were not fixed.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
>> Cc: Ryan Mallon <ryan at bluewatersys.com>
>
> I actually think this makes the file less readable in most cases:

Not a problem.  I just happened to run the script to see what happened.
I'll just leave everything as-is for now.

Thanks,
Hartley


More information about the linux-arm-kernel mailing list