[PATCH 5/6] arm/ns9xxx: fix debug macro compilation failure

[Russell King - ARM Linux]

On Thu, Jul 22, 2010 at 12:50:28PM +0200, Eric Miao wrote:
> On Thu, Jul 22, 2010 at 12:38 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > On Wed, Jul 14, 2010 at 10:32:39AM +0800, Jeremy Kerr wrote:
> >> We need mach/memory.h for NS9XXX_CSxSTAT_PHYS, and mach/memory.h needs
> >> asm/memory.h for UL().
> >
> > NAK.  Definitely NAK.  You haven't checked what includes whatelse.
> >
> > asm/memory.h includes mach/memory.h to pick up the platform specific
> > parts, and provides mach/memory.h with its pre-requisits.  Use asm/memory.h
> > _everywhere_ rather than mach/memory.h.
> >
> 
> I think it would be just fine to encode PHYS_OFFSET as 0xNNNNNNNNUL
> instead of using UL() if there is no specific reason. So we don't need
> to include asm/memory.h any more in machine specific code.

No it's not.  0xNNNNNNNNUL isn't able to be parsed by the assembler.
That's the whole reason for UL() existing.