[PATCH 5/6] arm/ns9xxx: fix debug macro compilation failure

[Eric Miao]

On Thu, Jul 22, 2010 at 12:38 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Wed, Jul 14, 2010 at 10:32:39AM +0800, Jeremy Kerr wrote:
>> We need mach/memory.h for NS9XXX_CSxSTAT_PHYS, and mach/memory.h needs
>> asm/memory.h for UL().
>
> NAK.  Definitely NAK.  You haven't checked what includes whatelse.
>
> asm/memory.h includes mach/memory.h to pick up the platform specific
> parts, and provides mach/memory.h with its pre-requisits.  Use asm/memory.h
> _everywhere_ rather than mach/memory.h.
>

I think it would be just fine to encode PHYS_OFFSET as 0xNNNNNNNNUL
instead of using UL() if there is no specific reason. So we don't need
to include
asm/memory.h any more in machine specific code.

> Doing otherwise will create include loops, which leads to unreliability
> in defined symbols.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>