[RFC,PATCH 3/3] arm: remove machine_desc.io_pg_offst and .phys_io
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Jul 22 05:46:43 EDT 2010
On Wed, Jul 21, 2010 at 11:09:15AM +0200, Jeremy Kerr wrote:
> Russell,
>
> > It's extremely unlikely to have a UART at address 0 (because that's by
> > default where the CPU jumps to on reset.) That's not to say it could
> > never happen - it's possible to hard-wire the CPU into 'hivec' mode
> > where it'll instead jump to 0xffff0000. In that case, if you're sane
> > you'd put your SDRAM at 0x00000000.
>
> OK, the patch I have just posted is a bit of a hack that does the 0x0
> check; happy to do this a different way.
>
> So, the simplest solution seems to be to make the uart mapping code
> dependent on !DEBUG_ICEDCC (but leave the code there to add the mappings
> for ARCH_NETWINDER, ARCH_CATS and ARCH_RPC). Would you like a new patch
> for this?
I think the last patch you posted is fine as-is. Compiling out the
setup code for the DEBUG_ICEDCC would be an optimization which could
be done though... If you think it's appropriate, please do so.
Meanwhile, I'm happy enough to merge this patch (or the optimized one)
and the follow-on patch which kills off the initializers.
Out of interest, have the OMAP platforms been compile tested with this?
More information about the linux-arm-kernel
mailing list