[PATCH] spinlock: don't use deprecated barriers on ARMv7

Rabin Vincent rabin at rab.in
Mon Jan 25 12:50:29 EST 2010


On Sun, Jan 24, 2010 at 08:42:33PM +0000, Russell King - ARM Linux wrote:
> > +static inline void smp_sev(void)
> > +{
> > +#if defined(CONFIG_SMP) && defined(CONFIG_CPU_32v6K)
> > +	dsb();
> > +	__asm__ __volatile__ ("sev" : : : "memory");
> 
> Why are you introducing a compiler memory barrier where there was none
> before?

I've removed it (and the additional memory barrier from the dsb()
helper) in the updated patch below.  I've also moved the helper into
spinlock.h itself, to avoid unnecessarily cluttering system.h:



More information about the linux-arm-kernel mailing list