Default machine include placements

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Jan 25 09:59:35 EST 2010


On Mon, Jan 25, 2010 at 01:54:45PM +0000, Ben Dooks wrote:
> On Mon, Jan 25, 2010 at 12:04:54PM +0000, Russell King - ARM Linux wrote:
> > Given the above, and the "mass population" hasn't happened, maybe part
> > of the solution to the duplicated header file problem is to start
> > combining some of these directories?
> 
> For plat-s3c64xx/mach-s3c6400/mach-s3c6410 how about moving the
> plat-s3c64xx in with the machine definitions, as it is quite clear
> now that it is unlikely to have any friends to join it (dev work is
> on s5p and onwards).
> 
> Either arch/arm/mach-s3c64xx and have all s3c6400 and s3c6410 machines
> in there, or keep the two mach- directories... I think i'd prefer to
> see the two directories culled into one.

I'd prefer that too.

> For the s3c24xx case, it probably is the best case to merges s3c2440 and
> s3c2442 into mach-s3c244x as they are pretty similar.
> 
> s3c2443 is on list of things to expand, it is a different beast to the
> predecessors.

Sounds like a reason to keep it separate for the time being.

> I'll try making patches for this tomorrow and see what people think?

I'm not sure where mach-s3c24a0 fits in to this stuff - the only thing
it seems to contain is a load of include files.

With these changes, it's going to take it from 10 mach-s[35]* directories
down to 8.  Not sure if it makes much material difference to mach/*.h
includes though.



More information about the linux-arm-kernel mailing list