[PATCH 3/4] rtc: enable rtc in max8925

[Alessandro Zummo]

On Mon, 25 Jan 2010 06:55:50 -0500
Haojian Zhuang <haojian.zhuang at gmail.com> wrote:

> On Mon, Jan 25, 2010 at 6:22 AM, Alessandro Zummo <a.zummo at towertech.it> wrote:
> > On Mon, 25 Jan 2010 06:09:04 -0500
> > Haojian Zhuang <haojian.zhuang at gmail.com> wrote:
> >
> >> +
> >> +static struct platform_driver max8925_rtc_driver = {
> >> +     .driver         = {
> >> +             .name   = "max8925-rtc",
> >> +             .owner  = THIS_MODULE,
> >> +     },
> >> +     .probe          = max8925_rtc_probe,
> >> +     .remove         = __devexit_p(max8925_rtc_remove),
> >> +};
> >> +
> >> +static int __init max8925_rtc_init(void)
> >> +{
> >> +     return platform_driver_register(&max8925_rtc_driver);
> >> +}
> >> +module_init(max8925_rtc_init);
> >> +
> >> +static void __exit max8925_rtc_exit(void)
> >
> >  this should be __devexit since you used __devexit_p
> >
> 
> I declared __devexit_p on max8925_rtc_remove. So I need to use
> __devexit on max8925_rtc_remove. I needn't use __devexit on
> max8925_rtc_exit, is it?

 Correct. My fault, sorry.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it