[RFC,PATCH 3/7 v2] arm/versatile: use generic struct clk
Jeremy Kerr
jeremy.kerr at canonical.com
Sun Jan 24 19:35:41 EST 2010
Hi Russell,
> This doesn't make any sense. What are you trying to do here?
>
> The get/put operations go together as one logical set - that's why you
> get both if you're using clkdev, and why you're asked to implement both
> __clk_get() and __clk_put() in arch code to do whatever's necessary
> with the clock.
I'm assuming that clk_put will be specific to the implementation; fixed clocks
probably won't need to do anything, but others may need a refcount, etc.
We don't have a struct clk to use clk_get on, so it remains a non-clock-
specific function.
We'll probably need the symmetry for some cases though, I think that a
__clk_get(struct clk *) member of clk_operations would work for this, to be
called by clk_get.
Cheers,
Jeremy
More information about the linux-arm-kernel
mailing list