[PATCH 1/7] [ARM] sa1100: remove unreferenced IRQ definitions

Thomas Kunze thommycheck at gmx.de
Thu Jan 21 13:01:31 EST 2010


Marek Vasut schrieb:
> Dne Čt 31. prosince 2009 14:23:56 Thomas Kunze napsal(a):
>   
>> Eric Miao wrote:
>>     
>>> These IRQ definitions related to LOCOMO are never referenced anywhere,
>>> thus could be safely removed.
>>>
>>> Signed-off-by: Eric Miao <eric.y.miao at gmail.com>
>>> ---
>>>  arch/arm/mach-sa1100/include/mach/collie.h |    7 -------
>>>  1 files changed, 0 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-sa1100/include/mach/collie.h
>>> b/arch/arm/mach-sa1100/include/mach/collie.h index 71a0b3f..52acda7
>>> 100644
>>> --- a/arch/arm/mach-sa1100/include/mach/collie.h
>>> +++ b/arch/arm/mach-sa1100/include/mach/collie.h
>>> @@ -72,13 +72,6 @@
>>>  #define COLLIE_IRQ_GPIO_GA_INT		IRQ_GPIO25
>>>  #define COLLIE_IRQ_GPIO_MAIN_BAT_LOW	IRQ_GPIO26
>>>
>>> -#define COLLIE_LCM_IRQ_GPIO_RTS		IRQ_LOCOMO_GPIO0
>>> -#define COLLIE_LCM_IRQ_GPIO_CTS		IRQ_LOCOMO_GPIO1
>>> -#define COLLIE_LCM_IRQ_GPIO_DSR		IRQ_LOCOMO_GPIO2
>>> -#define COLLIE_LCM_IRQ_GPIO_DTR		IRQ_LOCOMO_GPIO3
>>> -#define COLLIE_LCM_IRQ_GPIO_nSD_DETECT	IRQ_LOCOMO_GPIO13
>>> -#define COLLIE_LCM_IRQ_GPIO_nSD_WP	IRQ_LOCOMO_GPIO14
>>> -
>>>  /* GPIO's on the TC35143AF (Toshiba Analog Frontend) */
>>>  #define COLLIE_TC35143_GPIO_BASE	(GPIO_MAX + 13)
>>>  #define COLLIE_TC35143_GPIO_VERSION0    UCB_IO_0
>>>       
>> Those definitions are used in out-of-tree drivers. So please don't
>> remove them.
>>     
>
> Why aren't those in-the-tree already?
>   
Because I always seem to miss the right time to submit pull requests.
>> Regards,
>> Thomas
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>>     
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>   




More information about the linux-arm-kernel mailing list