[PATCH - 3rd attempt] ARM: Support for Embedian MXM-8x10 eval kit
Edwin Peer
epeer at tmtservices.co.za
Tue Jan 19 00:37:59 EST 2010
On Tuesday 19 January 2010 07:15:56 Hennie van der Merwe wrote:
> I originally wrote it like this because I wanted the option for the
> machine implementing the MXM-8x10 module to initialise the MMC or not.
> I'm not sure static is appropriate (as it is exported in the header).
> Could we perhaps drop the inline and just make it a void __init instead?
Indeed, those can't be made static. What I have done is make all the functions
we call in barebones_init() static and remove their declarations from the
header, since those are never optional.
> Agreed. This one must have just slipped by... Too much coffee, not
> enough sleep :)
Fixed. I've also corrected what I hope are the last formatting issues and
fixed one more #include that I somehow missed before.
I'm giving the changes a quick test on the hardware before submitting what I
hope will be the final patch.
Regards,
Edwin Peer
More information about the linux-arm-kernel
mailing list