[PATCH] ARM: Fix uncompress code compile for different definesof static(void)

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Jan 18 05:44:10 EST 2010


Hello Russell,

On Thu, Jan 14, 2010 at 11:38:15AM -0800, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux at arm.linux.org.uk> [100114 01:14]:
> > On Thu, Jan 14, 2010 at 09:29:52AM +0100, Uwe Kleine-König wrote:
> > > I think the cleanest solution would be to remove -Dstatic=.  I don't
> > > know the exact reason for it being there.
> > 
> > Thereby breaking the ability to build a relocatable decompressor.
> > 
> > > Russell, maybe these toolchain problems are gone in the meantime?
> > 
> > I don't think it was toolchain problems.  Having the text and data
> > segments independently relocatable is actually an abuse of the ELF
> > format - it's not something it directly supports.
> > 
> > From what I remember, having 'static' in there results in either
> > function calls or static data being indirected through the GOT table,
> > which means it has to be relocated along side the data segment - which
> > makes the offset between the text and data segments fixed.
> > 
> > I would not believe that the "problems" have gone because the toolchain
> > is working how it's supposed to.
> > 
> > The -Dstatic= stays.
> 
> I've added the compile fix with the subject fixed into Russell's
> patch system as 5882/1.
can you please take this patch as currently all imx based machines fail
the compile test because of this.

You can interpret this as an Acked-by: or Tested-by: or both.

Thanks
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list