[PATCH - 2nd attempt] ARM: Support for Embedian MXM-8x10 eval kit

Eric Miao eric.y.miao at gmail.com
Wed Jan 13 20:12:18 EST 2010


> > +
> > +static void __init capc7117_ide_init(void)
> > +{
> > +     pxa3xx_mfp_write(MFP_PIN_GPIO76, 0xa0c0);       /* EXT_IRQ3 */
>
> I'm not sure that pxa3xx_mfp_write is supposed to be used.  Eric?
>

No, we don't. Having magic number there is really painful to
understand and maintain. I guess for the statement above, one
can easily write this in a pin config array with macro:

GPIO76_GPIO,    /* EXT_IRQ3 */



More information about the linux-arm-kernel mailing list