[PATCH] ARM: Fix uncompress code compile for different defines of static(void)

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Jan 13 03:49:37 EST 2010


Hello,

On Tue, Jan 12, 2010 at 06:19:40PM -0800, Tony Lindgren wrote:
> Because of the include of the decompress_inflate.c file from
> boot/compress/misc.c, there are different flush() defines:
> 
> In file included from arch/arm/boot/compressed/misc.c:249:
> arch/arm/boot/compressed/../../../../lib/decompress_inflate.c:138:29: error: macro "flush" passed 2 arguments, but takes just 0
> 
> Fix this by removing the define of flush() in misc.c for
> CONFIG_DEBUG_ICEDCC as it's already defined in mach/uncompress.h,
> and that is being included unconditionally.
> 
> Also use a static inline function instead of define
> for mach-mxc and mach-gemini to avoid similar bug
> for those platforms.
As arch/arm/boot/compressed/misc.c is compiled with -Dstatic= and this
is AFAIK the only user of uncompress.h I'd skip "static" and/or add a
comment telling that static is redundant here.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list