[PATCH 00/35] davinci updates queued for 2.6.34

Kevin Hilman khilman at deeprootsystems.com
Mon Jan 11 10:31:57 EST 2010


Russell King - ARM Linux <linux at arm.linux.org.uk> writes:

> On Wed, Jan 06, 2010 at 10:31:42AM -0800, Kevin Hilman wrote:
>> Apologies for the large series, I've been meaning to send these in
>> smaller batches, but hd lots to queue up from over the holidays.
>> 
>> Pending any review comments, these will be submitted to Linus during
>> the next merge window.
>
> Nothing specific on this series.
>
> However, while looking at adding a standard clkdev_add_table() to replace
> all those clks_register() implementations found in various machine files
> (and open-coded versions of the same) I'm wondering why davinci wraps
> the clk_lookup structure without adding anything to it.

It's no longer needed.  In initial implementation, I had some extra
fields like in OMAP, but then dropped them. 

> Could davinci get rid of this seemingly useless wrapping (presumably
> copied from OMAP) and so be able to switch over to use clkdev_add_table()
> instead?

Yes, I'll drop the wrapping.

Thanks for the reviews,

Kevin



More information about the linux-arm-kernel mailing list