Ben, > Good point, will inline these. .. and now I remember why I didn't: linux/clk.h defines these as non-static. Alternative is to move the COMMON_STRUCT_CLK API to general kernel land, and put the definitions in the global clk.h. Cheers, Jeremy