[GIT PULL] omap fixes for 2.6.33-rc3
tony at atomide.com
Sat Jan 9 12:28:41 EST 2010
* Stephen Rothwell <sfr at canb.auug.org.au> [100108 18:45]:
> Hi Tony,
> On Fri, 8 Jan 2010 14:50:23 -0800 Tony Lindgren <tony at atomide.com> wrote:
> > Hmm, sounds like it might make sense to check for that in Stephen's
> > for-next tree then. Added Stephen to the loop, let's see if what he
> > thinks.
> I can certainly add hooks to my tree if someone can suggest what should
> be in them (I didn't get enough context here ...). That way I could send
> the tree maintainer a warning email letting them know something is
> fishy ...
Just trying to warn about unconfigured environment for GIT_AUTHOR_EMAIL
and GIT_COMMITTER_EMAIL that makes commits show from user at hostname.(none).
There are quite a few of them, but looks like none after v2.6.33-rc1.
So I guess the test would be to do a pull into for-next, then do a
git log of the pull to see if there were any unconfigured email
addresses. Then notify the maintainers if there were .(none) type
The git commands to test for these would be something like this:
ORIG=$(git log --pretty=format:"%H" -n1)
git pull whatevever
git log --pretty=format:"Bad author: %H %ae" --author=".(none)" $ORIG..HEAD
git log --pretty=format:"Bad committer: %H %ce" --committer=".(none)" $ORIG..HEAD
> Of course, this only helps those who don't mind rebasing their trees,
> right? The non-rebasing tree maintainers should do these checks
> themselves. Maybe we could propogate a suggested (or mandatory) set of
Right, this won't catch all of them, and might be too late in many
cases to fix the issue. But just letting the maintainers know about
issues might be enough to fix the problem.
More information about the linux-arm-kernel