> +/* Avengers lite MFP configurations */ > +static unsigned long avengers_lite_pin_config_V16F[] __initdata = { > + /* DEBUG_UART */ > + MFP_CFG(GPIO88, AF2), > + MFP_CFG(GPIO89, AF2), > +}; > + We may add these two definitions into mfp-pxa168.h so that other pxa168-based platform can reuse. Otherwise looks OK to me.