[PATCH] ARM: include needed linux/cpu.h in asm/cpu.h

Shilimkar, Santosh santosh.shilimkar at ti.com
Thu Jan 7 02:44:57 EST 2010


Russell,
Any comments on this patch ?
> -----Original Message-----
> From: Shilimkar, Santosh
> Sent: Sunday, January 03, 2010 5:05 PM
> To: linux at arm.linux.org.uk
> Cc: linux-arm-kernel at lists.infradead.org; tony at atomide.com; Shilimkar, Santosh
> Subject: [PATCH] ARM: include needed linux/cpu.h in asm/cpu.h
> 
> The file arch/arm/include/asm/cpu.h needs to include 'linux/cpu.h' to
> meet its dependency. Otherwise when using "struct cpuinfo_arm" and including
> just 'asm/cpu.h' throws below error -
> 	arch/arm/include/asm/cpu.h:16: error: field 'cpu' has incomplete type
> 
> To fix this  otherway, one can also include both linux/cpu.h and asm/cpu.h
> ubut it shoudn't be that way. So this patch fixes this by including the
> linux/cpu.h in asm/cpu.h,so that including alone asm/cpu.h is enough.
> 
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> ---
>  arch/arm/include/asm/cpu.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/include/asm/cpu.h b/arch/arm/include/asm/cpu.h
> index 634b2d7..7939681 100644
> --- a/arch/arm/include/asm/cpu.h
> +++ b/arch/arm/include/asm/cpu.h
> @@ -11,6 +11,7 @@
>  #define __ASM_ARM_CPU_H
> 
>  #include <linux/percpu.h>
> +#include <linux/cpu.h>
> 
>  struct cpuinfo_arm {
>  	struct cpu	cpu;
> --
> 1.6.0.4





More information about the linux-arm-kernel mailing list