[patch-v2.6.33-rc2+ 10/12] arm: omap: gpio: kill compile warning in gpio.c
Tony Lindgren
tony at atomide.com
Tue Jan 5 15:20:16 EST 2010
* Felipe Balbi <felipe.balbi at nokia.com> [091229 14:59]:
> when building linux-omap for omap1510, there will
> be a compile warning about the unused flags variable
> which is only used on 16xx and onwards.
>
> Signed-off-by: Felipe Balbi <felipe.balbi at nokia.com>
> ---
> arch/arm/plat-omap/gpio.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
> index 0484681..8c34b81 100644
> --- a/arch/arm/plat-omap/gpio.c
> +++ b/arch/arm/plat-omap/gpio.c
> @@ -1072,7 +1072,10 @@ static inline void _set_gpio_irqenable(struct gpio_bank *bank, int gpio, int ena
> */
> static int _set_gpio_wakeup(struct gpio_bank *bank, int gpio, int enable)
> {
> +#if defined(CONFIG_ARCH_OMAP16XX) || defined(CONFIG_ARCH_OMAP24XX) || \
> + defined(CONFIG_ARCH_OMAP34XX) || defined(CONFIG_ARCH_OMAP4)
> unsigned long flags;
> +#endif
>
Let's not add more ifdeffery to gpio.c.. How about
let's use uninitialized_var() instead? See the patch
below.
Regards,
Tony
More information about the linux-arm-kernel
mailing list