[PATCH 2/7] [ARM] locomo: avoid the unnecessary cascade of keyboard IRQ

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Jan 2 06:43:24 EST 2010


On Mon, Dec 28, 2009 at 01:18:03PM +0800, Eric Miao wrote:
> It is not necessary and over-complicated that IRQ_LOCOMO_KEY is a cascaded
> IRQ of IRQ_LOCOMO_KEY_BASE. Removed and introduced locomokbd_{open,close}
> for masking/unmasking of the keyboard IRQ.

What about removing these as well:

        /* install handlers for IRQ_LOCOMO_KEY_BASE generated interrupts */
        set_irq_chip(LOCOMO_IRQ_KEY_START, &locomo_key_chip);
        set_irq_chip_data(LOCOMO_IRQ_KEY_START, irqbase);
        set_irq_handler(LOCOMO_IRQ_KEY_START, handle_edge_irq);
        set_irq_flags(LOCOMO_IRQ_KEY_START, IRQF_VALID | IRQF_PROBE);

the locomo_key_chip structure, locomo_key_handler() itself, and the
associated handlers?  AFAICS, after this change, none of this is
used anymore.



More information about the linux-arm-kernel mailing list