21285 serial driver deadlock(?) fix
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri Jan 1 15:29:16 EST 2010
On Mon, Dec 28, 2009 at 05:27:06PM -0500, Steve Moskovchenko wrote:
> I've modified the ISR to call a different version of stop_tx, which uses
> disable_irq_nosync() instead. This gave me a working console.
That's right - however, I'm not sure whether the stop_rx also needs
to be a _nosync version.
> Another issue with the driver is the baud rate calculation, which seems
> broken for me. I had to comment out the lines that write to the BRG
> register (not in this patch), but this may be a result of my board using
> a different clock rate than a real EBSA285. Maybe I will look into that
Works for me. Could be that your 21285 is clocked at a different rate,
in which case the 21285 timers are also going to be wrong. You need to
specify the 21285 clock rate to the booting kernel via ATAGs or the
"mem_fclk_21285=" command line option.
There is no way for the kernel to autodetect this; it must be passed to
the kernel in some manner from something like a boot loader.
More information about the linux-arm-kernel