[PATCH] iop-adma: redundant/wrong tests in iop_*_count()?

Dan Williams dan.j.williams at intel.com
Sun Feb 28 22:58:14 EST 2010


On Sat, Feb 13, 2010 at 7:54 AM, Roel Kluin <roel.kluin at gmail.com> wrote:
> When we reach the loop, len is at least 1, we only stay in the loop when
> len is at least MAX_BYTE_COUNT + 1, MAX_BYTE_COUNT is subtracted in each
> iteration. So when we leave the loop, or didn't take it, len is at least 1.
> Testing whether len is non-zero appears redundant.
>
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
> ---
> Or are the tests off by one? Then we'll need a different patch...

No, not off by one, just redundant.

Applied, thanks.

--
Dan



More information about the linux-arm-kernel mailing list