[RESEND][PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init
Tony Lindgren
tony at atomide.com
Thu Feb 25 13:57:34 EST 2010
* Shilimkar, Santosh <santosh.shilimkar at ti.com> [100225 10:51]:
>
> > -----Original Message-----
> > From: Tony Lindgren [mailto:tony at atomide.com]
> > Sent: Friday, February 26, 2010 12:14 AM
> > To: Thomas Weber; Aguirre, Sergio
> > Cc: linux-omap at vger.kernel.org; Russell King; Kevin Hilman; Shilimkar, Santosh; Pandita, Vikram;
> > Syed, Rafiuddin; linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; Thomas Weber
> > Subject: Re: [RESEND][PATCH/RFC] OMAP2: serial.c: Fix number of uarts in early_init
> >
> > * Thomas Weber <swirl at gmx.li> [100225 01:36]:
> > >
> > > The omap_serial_early_init prints the following errors:
> > >
> > > Could not get uart4_ick
> > > Could not get uart4_fck
> > >
> > > because all the uarts available in omap_uart[] will be initialized.
> > > Only omap4430 and omap3630 have 4 uarts at the moment.
> > > This patch reduces the number of uarts when cpu is not omap4430 or
> > > omap3630.
> >
> > ..and I only patched omap_serial_init and forgot about
> > the omap_serial_early_init..
> >
> > Looks good to me, Sergio, care to test and Ack this? Also, sounds
> > like we still need to patch omap4 for uart4 for the clocks.
> >
> Clocks will be take care automatically by "nr_ports" for omap4 too
> with this patch. Below clock changes are just cosmetic ones, isn't it ?
>
> Am I missing something?
Yes sorry, I'm referring to "[RFC][PATCH 0/3] OMAP3630: UART4 startup"
series to fix the uart4 issues for 3630, not omap4.
Regards,
Tony
More information about the linux-arm-kernel
mailing list