[PATCH] ARM: MMCI: support 8bit mode on the ST Micro version

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Feb 24 17:41:59 EST 2010


On Wed, Feb 24, 2010 at 10:49:49PM +0100, Linus Walleij wrote:
> +	if (host->mmc->ios.bus_width == MMC_BUS_WIDTH_8) {
> +		if (host->hw_designer == AMBA_VENDOR_ST)
> +			clk |= MCI_8BIT_BUS;
> +		else
> +			dev_err(mmc_dev(host->mmc),
> +				"8bit bus mode requested but not available\n");
> +	}

Hmm.  I don't think this is necessary - just arrange for the 8-bit
capability flag to be cleared for non-ST devices.

It might be a good idea to call this register bit 'MCI_ST_8BIT_BUS'
so that people don't mistake it as something present on all
implementations.



More information about the linux-arm-kernel mailing list