[PATCH 2/4] s3c24xx_ts: report touch only when stylus is down

Dmitry Torokhov dmitry.torokhov at gmail.com
Sun Feb 21 17:51:25 EST 2010


On Sun, Feb 21, 2010 at 11:44:34PM +0200, Vasily Khoruzhick wrote:
> В сообщении от 21 февраля 2010 16:27:13 автор Nelson Castillo написал:
> > I remember I got bit by this also when I scheduled more conversions
> > without a timer; pen-up event would not get noticed. I didn't check
> > the specs to see if there was a way to configure the HW to do
> > otherwise.
> 
> UPDOWN bits in ADCDAT0 and ADCDAT1 are valid only in WAIT4INT mode, it's wrong 
> to check them in select callback because ADC is not in WAIT4INT mode.

We do put it in WAIT4INT mode rigtht there though so it looks like we
just need to move that call (well the original doing WAIT4INT | INT_UP)
before we check for pen state.

-- 
Dmitry



More information about the linux-arm-kernel mailing list