[PATCH 2/4] s3c24xx_ts: report touch only when stylus is down

Dmitry Torokhov dmitry.torokhov at gmail.com
Sun Feb 21 05:28:07 EST 2010


On Sun, Feb 21, 2010 at 12:10:08PM +0200, Vasily Khoruzhick wrote:
> В сообщении от 21 февраля 2010 11:41:51 автор Dmitry Torokhov написал:
> > > Timer is used to avoid reporting input events in interrupt context
> > > (select callback is called from s3c_adc_try and from s3c_adc_irq),
> > ??? This is quite a novel concept for me...
> 
> I think so, as I don't see any other reasons to use timer :)
> 
> > > Anyway, driver
> > > doesn't work for me with this patch (it works as mouse, but it doesn't as
> > > touchscreen through tslib)
> > 
> > Hmm, does evtest utility report all expected events?
> 
> evtest shows that driver starts event flood on first touch, i.e. it doesn't 
> stop to emit event when stylus is up.
> 

While flooding does it report BTN_TOUCH as up or down? I might have messed
s3c24xx_ts_check_pen_down()...

-- 
Dmitry



More information about the linux-arm-kernel mailing list