[PATCH 2/4] s3c24xx_ts: report touch only when stylus is down
Dmitry Torokhov
dmitry.torokhov at gmail.com
Sun Feb 21 04:41:51 EST 2010
On Sun, Feb 21, 2010 at 11:05:26AM +0200, Vasily Khoruzhick wrote:
> В сообщении от 21 февраля 2010 09:35:13 автор Dmitry Torokhov написал:
>
> > Applied, thank you Vasily.
> >
> > One more thing though - why do we need that timer to report input events
> > and reschedule ADC conversions? It looks like it is not really needed.
> > Could you please give a try to the patch below?
> >
> > Thanks!
>
> Timer is used to avoid reporting input events in interrupt context (select
> callback is called from s3c_adc_try and from s3c_adc_irq),
??? This is quite a novel concept for me...
> Is it safe to call
> input_report_abs/input_report_key from interrupt context?
Yes.
> Anyway, driver
> doesn't work for me with this patch (it works as mouse, but it doesn't as
> touchscreen through tslib)
Hmm, does evtest utility report all expected events?
--
Dmitry
More information about the linux-arm-kernel
mailing list