[PATCH][KS8695] Mark network interface as running on ifconfig up

David Miller davem at davemloft.net
Tue Feb 16 19:06:47 EST 2010


From: Yegor Yefremov <yegor_sub1 at visionsystems.de>
Date: Thu, 11 Feb 2010 12:12:43 +0100

> [KS8695] Mark network interface as running on ifconfig up
> 
> Without netif_carrier_on() network interface will not transmit any packets
> after ifconfig down and subsequent ifconfig up.
> 
> Signed-off-by: Yegor Yefremov <yegorslists at googlemail.com>
> 
> Index: linux-2.6.33-rc7/drivers/net/arm/ks8695net.c
> ===================================================================
> --- linux-2.6.33-rc7.orig/drivers/net/arm/ks8695net.c
> +++ linux-2.6.33-rc7/drivers/net/arm/ks8695net.c
> @@ -1371,6 +1371,7 @@ ks8695_open(struct net_device *ndev)
>  
>  	napi_enable(&ksp->napi);
>  	netif_start_queue(ndev);
> +	netif_carrier_on(ndev);
>  
>  	return 0;
>  }
> 

Only ks8695_link_irq() should be setting the carrier state.

If necessary, reset the PHY on device open so that the link up
interrupt arrives and the code handling that event can set the carrier
status properly.

This is how every other driver handles this situation.




More information about the linux-arm-kernel mailing list