[PATCH 12/14] AMBA: CLCD: LPC32XX register swap in the clcd header file

Kevin Wells kevin.wells at nxp.com
Tue Feb 16 15:27:17 EST 2010



> > >
> > > On Mon, Feb 08, 2010 at 04:11:33PM -0800, wellsk40 at gmail.com wrote:
> > > > The CTRL and IENB registers need to be swapped for the LPC32XX
> > > > arch.
> > >
> > > Is your peripheral a PL110 or PL111 ?
> > >
> >
> > This part uses an unmodified PL111.
> 
> In which case, could you test this patch please:
> 
>     Video: ARM CLCD: Better fix for swapped IENB and CNTL registers
> 
>     On PL111, as found on Realview and other platforms, these registers
> are
>     always arranged as CNTL then IENB.  On PL110, these registers are IENB
>     then CNTL, except on Versatile platforms.
> 
>     Re-arrange the handling of these register swaps so that PL111 always
>     gets it right without resorting to ifdefs, leaving the only case
> needing
>     special handling being PL110 on Versatile.
> 
>     Fill out amba/clcd.h with the PL110/PL111 register definition
>     differences in case someone tries to use the PL110 specific
> definitions
>     on PL111.
> 
>     Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> 

Patch tested and works fine on our PL111 hardware. Sorry, I have no
PL110 hardware to test it against.

>  drivers/video/amba-clcd.c |   31 ++++++++++++++++++++++++-------
>  include/linux/amba/clcd.h |   33 +++++++++++++++++----------------
>  2 files changed, 41 insertions(+), 23 deletions(-)
> 




More information about the linux-arm-kernel mailing list