[PATCH] Eurotech Zeus : Making USB port 2 work

Marc Zyngier maz at misterjones.org
Thu Feb 11 04:32:40 EST 2010


On Thu, February 11, 2010 07:03, Amit Walambe wrote:
> Hi!
> Thanks for your comments Marc.
>
> On Wed, 10 Feb 2010 09:38:38 -0000 (GMT)
> "Marc Zyngier" <maz at misterjones.org> wrote:
>> >  static struct pxaohci_platform_data zeus_ohci_platform_data = {
>> >  	.port_mode	= PMM_NPS_MODE,
>> > -	.flags		= ENABLE_PORT_ALL |
>> > POWER_CONTROL_LOW | POWER_SENSE_LOW,
>> > +	/* Clear Power Control Polarity Low and set Power Sense
>> > +	 * Polarity Low. Supply power to USB ports. */
>> > +	.flags		= ENABLE_PORT_ALL |
>> > ~(POWER_CONTROL_LOW) | POWER_SENSE_LOW,
>>
>> I suppose that is actually what makes it work, though the change is
>> rather suspect. You're basically setting *all* bits to 1
> My bad. Attaching a modified patch. I have tested it on a Zeus and it
> works ok.

Thanks. Both patches queued for 2.6.34.

        M.
-- 
And if you don't know where you're going, any road will take you there...





More information about the linux-arm-kernel mailing list