[PATCH 2/3] mx25: add platform support for imxfb

[Uwe Kleine-König]

Hi,

On Wed, Feb 10, 2010 at 09:25:19AM +0200, Baruch Siach wrote:
> @@ -233,6 +242,9 @@ int __init mx25_clocks_init(void)
>  	__raw_writel((0xf << 16) | (3 << 26), CRM_BASE + CCM_CGCR1);
>  	__raw_writel((1 << 5), CRM_BASE + CCM_CGCR2);
>  
> +	/* Clock source for lcdc is upll */
> +	__raw_writel(__raw_readl(CRM_BASE+0x64) | (1 << 7), CRM_BASE + 0x64);
> +
0x64?  Please define a register name for that constant.  Ditto for 7.

Note I didn't look in the hardware manual, but I wonder if that should
better go in the enable routine for lcdc?


Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |