[PATCH] input: mark {corgi,spitz,tosa}kbd driver deprecated

Pavel Machek pavel at ucw.cz
Mon Feb 8 13:05:08 EST 2010


Hi!

>     input: mark {corgi,spitz,tosa}kbd driver deprecated
> 
>     Provided that now keyboards on these devices are now fully supported
>     by generic GPIO based matrix keypad driver, mark these hardcoded, and
>     difficult to maintain drivers deprecated in favour of this.
> 
>     Cc: Richard Purdie <rpurdie at rpsys.net>
>     Cc: Dmitry Eremin-Solenikov <dbaryshkov at gmail.com>
>     Signed-off-by: Eric Miao <eric.y.miao at gmail.com>

ACK, but..

> @@ -329,13 +332,16 @@ config KEYBOARD_PXA930_ROTARY
>  	  module will be called pxa930_rotary.
> 
>  config KEYBOARD_SPITZ
> -	tristate "Spitz keyboard"
> +	tristate "Spitz keyboard (deprecated)"
>  	depends on PXA_SHARPSL
>  	default y

Default should be N, and config option probably should be removed
altogether -- with recent mach_spitz, keyboard_spitz will not be bound
to the hw, anyway... right?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



More information about the linux-arm-kernel mailing list