[PATCH 4/5] ARM: L2 : Errata 588369: Clean & Invalidate do not invalidate clean lines

[Shilimkar, Santosh]

> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Sent: Thursday, February 04, 2010 8:13 PM
> To: Shilimkar, Santosh
> Cc: tony at atomide.com; Woodruff, Richard; catalin.marinas at arm.com; linux-arm-
> kernel at lists.infradead.org; linux-omap at vger.kernel.org
> Subject: Re: [PATCH 4/5] ARM: L2 : Errata 588369: Clean & Invalidate do not invalidate clean lines
> 
> On Thu, Feb 04, 2010 at 07:55:46PM +0530, Santosh Shilimkar wrote:
> > diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> > index 1a14d18..6241f10 100644
> > --- a/arch/arm/mm/cache-l2x0.c
> > +++ b/arch/arm/mm/cache-l2x0.c
> > @@ -56,12 +56,41 @@ static inline void l2x0_inv_line(unsigned long addr)
> >  	writel(addr, base + L2X0_INV_LINE_PA);
> >  }
> >
> > +#ifdef CONFIG_PL310_ERRATA_588369
> > +extern void omap_smc1(u32 fn, u32 arg);
> > +static void debug_writel(unsigned long val)
> > +{
> 
> You could move the external declaration into this function, thereby
> making it entirely local to this function (and hiding it from the
> file scope.)
OK