[PATCH 1/2] Modify PL031 for Nomadik and U8500 v2

Alessandro Zummo a.zummo at towertech.it
Thu Feb 4 04:42:22 EST 2010

On Thu,  4 Feb 2010 09:45:23 +0100
Linus Walleij <linus.walleij at stericsson.com> wrote:

> This extends the existing PrimeCell PL031 driver with support for
> the ST Microelectronics and ST-Ericsson derivatives, in a first
> and second version as used on the Nomadik and U8500 platforms.
> It also rids the old ioctl() alarm on/off functions in favor of
> the new .alarm_irq_enable field of the RTC class ops.
> Signed-off-by: Linus Walleij <linus.walleij at stericsson.com>

 Acked-by: Alessandro Zummo <a.zummo at towertech.it>

> If you Ack this Alessandro, is it OK that I put it in through
> Russells patch tracker and ARM tree?
 Ok. Be sure to have it tested on both versions
 of the rtc.

  Please also correct white lines between a function call
 and the related if:

> +	ret = pl031_stv2_tm_to_time(dev, tm, &time, &bcd_year);
----> +
> +	if (ret == 0) {
> +		writel(bcd_year, ldata->base + RTC_YLR);
> +		writel(time, ldata->base + RTC_LR);
> +	}

 I've seen a couple of those.


 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy


More information about the linux-arm-kernel mailing list