[PATCH] MX1/MX2: -EINVAL overwritten in second iteration in mxc_gpio_setup_multiple_pins()

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Feb 3 15:56:09 EST 2010


On Wed, Feb 03, 2010 at 08:19:00PM +0100, Roel Kluin wrote:
> Due to the `ret = gpio_request()' below in the loop, the initial -EINVAL value
> of ret is overwritten. 
> 
> Signed-off-by: Roel Kluin <roel.kluin at gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

> ---
> Not 100% sure this is needed, please review. One more question: is it ok
> to return 0 when count is 0 (and nothing is done)?
I'd say yes.  If you want nothing from me, I can say I gave you all you
wanted without doing anything.

Thanks
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list