[PATCH 1/9] omap: define _toggle_gpio_edge_triggering only for OMAP1

Tony Lindgren tony at atomide.com
Wed Feb 3 11:57:55 EST 2010


* Uwe Kleine-König <u.kleine-koenig at pengutronix.de> [100203 00:10]:
> Hi Tony,
> 
> On Tue, Feb 02, 2010 at 06:25:55PM -0800, Tony Lindgren wrote:
> > From: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> > 
> > The only usage of _toggle_gpio_edge_triggering is in an
> > CONFIG_ARCH_OMAP1 is defined, too.
> This sentence is broken, isn't it?  I guess git commit played tricks on
> me here and removed a line, something like:
> 
> 	#ifdef CONFIG_ARCH_OMAP1 block, so only provide it if
> 
> Can you add it back?  I'd recommend doing the line break before the "an"
> in the first line instead of behind it.

Sure, updated patch below. The description makes more sense now :)

BTW, looks like with "git show --pretty=email" the From: field gets
messed up in the patch below. Author name shows OK in git though.

I wonder if that's a git bug for --pretty=email? Using version
1.6.6.1 it seems.

Tony


More information about the linux-arm-kernel mailing list