[PATCHv2 01/11] arm: mxc: TrustZone interrupt controller (TZIC) for i.MX5 family
eric.y.miao at gmail.com
Wed Feb 3 10:09:57 EST 2010
On Wed, Feb 3, 2010 at 5:24 AM, Amit Kucheria
<amit.kucheria at canonical.com> wrote:
> On 10 Feb 02, Eric Miao wrote:
>> Hi Amit,
>> Just some nit-picking review comments, see below:
>> On Tue, Feb 2, 2010 at 9:16 PM, Amit Kucheria
>> <amit.kucheria at canonical.com> wrote:
>> > Freescale i.MX51 processor uses a new interrupt controller. Add
>> > driver for TrustZone Interrupt Controller
>> > Signed-off-by: Amit Kucheria <amit.kucheria at canonical.com>
>> > ---
>> > arch/arm/plat-mxc/Kconfig | 8 ++
>> > arch/arm/plat-mxc/Makefile | 3 +
>> > arch/arm/plat-mxc/tzic.c | 182 ++++++++++++++++++++++++++++++++++++++++++++
>> > 3 files changed, 193 insertions(+), 0 deletions(-)
>> > create mode 100644 arch/arm/plat-mxc/tzic.c
>> > diff --git a/arch/arm/plat-mxc/Kconfig b/arch/arm/plat-mxc/Kconfig
>> > index 8b0a1ee..59558c4 100644
>> > --- a/arch/arm/plat-mxc/Kconfig
>> > +++ b/arch/arm/plat-mxc/Kconfig
>> > @@ -62,6 +62,14 @@ config MXC_IRQ_PRIOR
>> > requirements for timing.
>> > Say N here, unless you have a specialized requirement.
>> > +config MXC_TZIC
>> > + bool "Enable TrustZone Interrupt Controller"
>> > + depends on ARCH_MX51
>> This is the first patch of the base port, yet I cannot find any reference to
>> this ARCH_MX51, did you miss something?
> ARCH_MX51 is only introduced in the later patches that add the core i.MX5
> code. Since TZIC is not inherently dependent on i.MX5 (it's merely the first
> processor to use it), I thought of splitting it out as a separate patch.
> Does this break the sanctity of one self-contained change?
This breaks git-bisect, we may want a buildable kernel every commit if possible.
>> > + help
>> > + This will be automatically selected for all processors
>> > + containing this interrupt controller.
>> > + Say N here only if you are really sure.
>> > +
> Thanks for the review.
No problem, dude.
More information about the linux-arm-kernel