[PATCH 2/2] ftrace: re-enable dynamic ftrace for ARM
rabin at rab.in
Mon Feb 1 11:53:19 EST 2010
On Mon, Feb 01, 2010 at 11:28:43AM +0100, Uwe Kleine-König wrote:
> On Sun, Jan 31, 2010 at 11:03:16PM +0530, Rabin Vincent wrote:
> > This adds mcount recording and updates dynamic ftrace for ARM to work
> > with the new ftrace dyamic tracing implementation.
> Wouldn't it be nice to patch out the instruction pushing lr to the
> stack (in the gnu case)? Should work, shouldn't it.
It would and it should, but the main reasons I didn't do that were:
- Thumb-2 support needs the LR to be in place, since even -mapcs-frame
does not seem to give us an APCS frame there. The LR would also
be needed if GCC gains the ability to build without frame pointers
- I'm not sure we would gain much performance by patching it out, and
I'd really like to avoid patching more than what is really necessary
and to keep the code as similar as possible to the other arches.
More information about the linux-arm-kernel