[PATCH] rtc: driver for the DryIce block found in i.MX25 chips

Baruch Siach baruch at tkos.co.il
Mon Feb 1 03:28:08 EST 2010


Hi Lothar,

On Mon, Feb 01, 2010 at 09:08:37AM +0100, Lothar Waßmann wrote:
> Just one nitpick, I didn't notice when replying to your first mail...
> Baruch Siach writes:
> [...]
> > +static inline void di_int_enable(struct imxdi_dev *imxdi, u32 intr)
> > +{
> > +	unsigned long flags;
> > +
> > +	spin_lock_irqsave(&imxdi->irq_lock, flags);
> > +	__raw_writel(__raw_readl(imxdi->ioaddr+DIER) | intr,
>                                             ^
> > +			imxdi->ioaddr+DIER);
>                            ^
> >
> Spaces around operators are welcome in the kernel.

Thanks for your review.
Will fix in the next version.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the linux-arm-kernel mailing list