[patch 1/5] ehci-mxc: Enable vbus later

Arnaud Patard (Rtp) arnaud.patard at rtp-net.org
Thu Dec 23 15:15:41 EST 2010


Sascha Hauer <s.hauer at pengutronix.de> writes:

> On Mon, Dec 20, 2010 at 04:48:54PM +0100, Arnaud Patard wrote:
>> vbus should be enabled after usb_add_hcd() otherwise USB is not working
>> on my efikamx.
>
> There is really something wrong with the way we handle initialization of
> the mxc ehci controller. There are frequently patches posted trying to
> change this order, and I think we are at a point where we can't move
> anymore without possibly breaking some other board. Should this be
> completely board dependend in the end?

I'm not aware of any other bug except the postsc setting one (which was
that any code trying to read the ulpi register without making sure that
portsc is configured for ulpi is buggy). Moreover, the change is
following the fsl bsp. I know it's not necessary the best code of the
world but I believe it has been tested on a lot of imx platforms.


Arnaud



More information about the linux-arm-kernel mailing list