[PATCH 1/6 v8] ARM: Add basic architecture support for VIA/WonderMedia 85xx SoC's

Alexey Charkov alchark at gmail.com
Mon Dec 20 14:26:22 EST 2010


2010/12/20 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> On Sun, Dec 19, 2010 at 08:40:17PM +0300, Alexey Charkov wrote:
>> +config ARCH_VT8500
>> +     bool "VIA/WonderMedia 85xx"
>> +     select CPU_ARM926T
>> +     select GENERIC_GPIO
>> +     select ARCH_HAS_CPUFREQ
>> +     select GENERIC_TIME
>
> Everything looks good, except for the above.  You don't need to select
> GENERIC_TIME - it doesn't exist anymore.

Ok, that was an old copy-paste. Will resubmit a revised version in a moment.

> It's also good to see that you've picked up on registering clocksources
> with the _hz/_khz functions.

Yes, these are quite handy. I will also check if my previously spotted
performance issues with sched_clock are relieved with the latest
clocksource-related instrumentary in 'devel': maybe it wasn't all due
to evil busy-waiting on counter-to-bus synchronization. However, that
would probably be worth a separate small patch.

Thanks,
Alexey



More information about the linux-arm-kernel mailing list