[PATCH 2/6] OMAP4: Pandaboard: Add omap_reserve functionality

Tony Lindgren tony at atomide.com
Sat Dec 18 12:20:56 EST 2010


* Russell King - ARM Linux <linux at arm.linux.org.uk> [101218 00:26]:
> On Fri, Dec 17, 2010 at 07:05:21PM -0800, Tony Lindgren wrote:
> >  	/* Maintainer: David Anders - Texas Instruments Inc */
> >  	.boot_params	= 0x80000100,
> >  	.map_io		= omap4_panda_map_io,
> > +	.reserve	= omap_reserve,
> 
> Please put .reserve before .map_io.

Hmm, that's the way it should be.. But we should also correct the
earlier changes too?

See 98c672cf1fa2a56f6f43e3f48b1208b83845582c (ARM: Move platform memory
reservations out of generic code) and 71ee7dad9b69917079f24d42aff796bad7932914
(ARM: OMAP: Convert to use ->reserve method to reserve boot time memory).

In these patches .reserve is also after .map_io which is
probably not intentional?

Regards,

Tony



More information about the linux-arm-kernel mailing list