[PATCH 14/17] ARM: S5PV310: Define I2S clocks

Jassi Brar jassisinghbrar at gmail.com
Fri Dec 17 01:14:59 EST 2010


On Fri, Dec 17, 2010 at 3:02 PM, Kyungmin Park <kmpark at infradead.org> wrote:
> On Fri, Dec 17, 2010 at 2:51 PM, Jassi Brar <jassisinghbrar at gmail.com> wrote:
>> On Fri, Dec 17, 2010 at 2:44 PM, Kyungmin Park <kmpark at infradead.org> wrote:
>>>
>>> Don't you use the i2s instead of iis?
>>
>> The already present driver expects 'iis' so we have to call it so, atm.
>
> Then code clean is first?
Yes, the code needs cleaning, but i have more important tasks right now.

> Your logic same as you complained about code consistency.
Nopes.
If I simply change from 'iis' to 'i2s' here, audio would break.
My suggestion, the other day, to simply drop brackets from around
_constants_ couldn't break anything. And I didn't ask anybody to first
submit patch that removes all instances of brackets around constants.



More information about the linux-arm-kernel mailing list