[PATCH v4 5/5] OMAP: mailbox: use runtime pm for clk and sysc handling

Kanigeri, Hari h-kanigeri2 at ti.com
Thu Dec 16 16:16:30 EST 2010


On Thu, Dec 16, 2010 at 11:01 AM, Ramirez Luna, Omar
<omar.ramirez at ti.com> wrote:
> Hi,
>
> On Thu, Dec 16, 2010 at 10:32 AM, Kanigeri, Hari <h-kanigeri2 at ti.com> wrote:
>>> @@ -130,12 +120,6 @@ static int omap2_mbox_startup(struct omap_mbox *mbox)
>>>        l = mbox_read_reg(MAILBOX_REVISION);
>>>        pr_debug("omap mailbox rev %d.%d\n", (l & 0xf0) >> 4, (l & 0x0f));
>>>
>>> -       if (cpu_is_omap44xx())
>>> -               l = OMAP4_SMARTIDLE;
>>> -       else
>>> -               l = SMARTIDLE | AUTOIDLE;
>>> -       mbox_write_reg(l, MAILBOX_SYSCONFIG);
>>> -
>>
>> The OMAP4 mailbox sysconfig register bits are laid out differently
>> from previous OMAP mailbox's. Example is smart idle bit location is
>> different from previous OMAPs. Can I know as how are you handling this
>> aspect in hwmod code ?
>
> hwmod framework provides definition for both IP models
> (omap_hwmod_sysc_type1for omap2/3 or omap_hwmod_sysc_type2 for omap4),
> these are located at arch/arm/mach-omap2/omap_hwmod_common_data.c
>

Thanks, Omar.

Best regards,
Hari Kanigeri



More information about the linux-arm-kernel mailing list