[PATCH v3] OMAP3: clean up ASM idle code

Jean Pihet jean.pihet at newoldbits.com
Thu Dec 16 13:17:04 EST 2010


On Tue, Dec 14, 2010 at 11:42 PM, Tony Lindgren <tony at atomide.com> wrote:
> Hi Jean,
> * jean.pihet at newoldbits.com <jean.pihet at newoldbits.com> [101214 09:28]:
>> From: Jean Pihet <j-pihet at ti.com>
>> This patch only contains clean-ups and cosmetic changes,
>> no functional change.
>> Clean up of the ASM code:
>> - reorganized the code in logical sections: defines, API
>>    functions, internal functions and variables,
>> - reworked and simplified the execution paths, for better
>>    readability and to avoid duplication of code,
>> - added comments on the entry and exit points and the interaction
>>    with the ROM code for OFF mode restore,
>> - reworked the existing comments for better readability,
>> - reworked the code formating, alignment and white spaces,
>> - added comments for the i443 erratum workarounds,
>> - changed the hardcoded values in favor of existing macros
>>    from include files,
>> - clean up of non used symbols.
> Can you please split it further, it's not obvious from reading it
> that it does not change anything.
That makes sense indeed.

> How about first do one or more patches to move the code around.
> Then rework the comments and formatting.
I just re-sent the changes as a series '[PATCH 0/7 v4] OMAP3: clean up
ASM sleep code'.
The patches are now much more readable and it also allowed me to solve
issues in a more generic way, cf. for example '[PATCH 2/7] OMAP2+: use
global values for the SRAM PA addresses'.

> Thanks,
> Tony


More information about the linux-arm-kernel mailing list