[PATCH 12/24] ARM: PXA: update clock source registration

Russell King - ARM Linux linux at arm.linux.org.uk
Thu Dec 16 05:38:29 EST 2010


On Tue, Dec 14, 2010 at 11:09:21AM +0800, Eric Miao wrote:
> On Tue, Dec 14, 2010 at 3:19 AM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
> > In d7e81c2 (clocksource: Add clocksource_register_hz/khz interface) new
> > interfaces were added which simplify (and optimize) the selection of the
> > divisor shift/mult constants.  Switch over to using this new interface.
> >
> 
> Russell,
> 
> This has been already addressed in Haojian's previous patch posted and
> merged in my tree:
> 
> http://git.kernel.org/?p=linux/kernel/git/ycmiao/pxa-linux-2.6.git;a=commitdiff;h=ee5ed917c3c412e0e13d1c198b5f09f82c03eea4
> 
> I'll send the pull request out early today to sort this out.

That's not quite the same.  clocksource_calc_mult_shift() was introduced
in November 2009, whereas clocksource_register_hz() was introduced in
May 2010.  I'm updating everything to the latest interface.

The newer interface removes the burden of having to figure out what to
pass as the 'minsec' parameter, as well as simplifying the clocksource
registration code down to one line.




More information about the linux-arm-kernel mailing list