[PATCH 3/3] omap2+: Initialize omap_irq_base for entry-macro.Sfrom platform code

Tony Lindgren tony at atomide.com
Tue Dec 14 22:25:38 EST 2010


* Rajendra Nayak <rnayak at ti.com> [101213 03:57]:
> >
> > +static inline void omap_irq_base_init(void)
> > +{
> > +	extern void __iomem *omap_irq_base;
> > +
> > +#ifdef MULTI_OMAP2
> > +	if (cpu_is_omap242x())
> 
> Looks like this should be a cpu_is_omap24xx(). The
> current master is broken on a 2430sdp and a git-bisect
> pointed me to this patch.

Thanks, just noticed that too. Here's a fix for that.

Regards,

Tony


From: Tony Lindgren <tony at atomide.com>
Date: Tue, 14 Dec 2010 19:17:31 -0800
Subject: [PATCH] omap: Fix setting omap_irq_base for 2430

We need to test for 24xx not 242x. Otherwise interrupts won't work.

Reported-by: Rajendra Nayak <rnayak at ti.com>
Signed-off-by: Tony Lindgren <tony at atomide.com>

--- a/arch/arm/mach-omap2/io.c
+++ b/arch/arm/mach-omap2/io.c
@@ -320,7 +320,7 @@ static inline void omap_irq_base_init(void)
 	extern void __iomem *omap_irq_base;
 
 #ifdef MULTI_OMAP2
-	if (cpu_is_omap242x())
+	if (cpu_is_omap24xx())
 		omap_irq_base = OMAP2_L4_IO_ADDRESS(OMAP24XX_IC_BASE);
 	else if (cpu_is_omap34xx())
 		omap_irq_base = OMAP2_L4_IO_ADDRESS(OMAP34XX_IC_BASE);



More information about the linux-arm-kernel mailing list