[PATCH v1 4/9] OMAP2430: hwmod data: add system DMA

[Paul Walmsley]

On Sat, 4 Dec 2010, G, Manjunath Kondaiah wrote:

> Add OMAP2430 DMA hwmod data and also add required
> DMA device attributes.

...

> +/* dma_system -> L3 */
> +static struct omap_hwmod_ocp_if omap2430_dma_system__l3 = {
> +	.master		= &omap2430_dma_system_hwmod,
> +	.slave		= &omap2430_l3_main_hwmod,
> +	.clk		= "l3_div_ck",

This clock does not exist on OMAP2430.  Did you test this on OMAP2430?

> +/* l4_cfg -> dma_system */
> +static struct omap_hwmod_ocp_if omap2430_l4_core__dma_system = {
> +	.master		= &omap2430_l4_core_hwmod,
> +	.slave		= &omap2430_dma_system_hwmod,
> +	.clk		= "l4_div_ck",

This clock also does not exist on OMAP2430.

> +static struct omap_hwmod omap2430_dma_system_hwmod = {
> +	.name		= "dma",
> +	.class		= &omap2430_dma_hwmod_class,
> +	.mpu_irqs	= omap2430_dma_system_irqs,
> +	.mpu_irqs_cnt	= ARRAY_SIZE(omap2430_dma_system_irqs),
> +	.main_clk	= "l3_div_ck",

Nor does this one.

Please fix these and test on OMAP2430 before resending.


- Paul