[PATCH] OMAP1: clock_data: use runtime cpu / machine checks

Paul Walmsley paul at pwsan.com
Mon Dec 13 04:24:59 EST 2010


Hello Janusz, Cory,

On Sat, 11 Dec 2010, Janusz Krzysztofik wrote:

> Otherwise multi-omap1 configurations may set wrong clock speed.
> 
> Created and tested against l-o master on Amstrad Delta.
> 
> Signed-off-by: Janusz Krzysztofik <jkrzyszt at tis.icnet.pl>

Thanks, this is a significant step forward in building a good 
omap1_defconfig.  Cory, do you mind testing this out?  If it works for you 
also, let's plan to take this for 2.6.38.

However:

> Tested with omap1_defconfig after dropping 
> CONFIG_OMAP_CLOCKS_SET_BY_BOOTLOADER=y and those of 12MHz xtal based 
> clock speeds which are too high for my board.

This is also key.  Until the board files can somehow indicate which rate 
sets are usable for their boards at runtime -- which is what the 
CONFIG_OMAP_ARM* KConfig options used to do at KConfig-time -- I don't 
think omap1_defconfig is possible yet.

Volunteers to tackle that project are gladly welcome :-)


- Paul



More information about the linux-arm-kernel mailing list